Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Sponsors list to footer #4424

Merged
merged 3 commits into from Aug 15, 2018
Merged

Add Sponsors list to footer #4424

merged 3 commits into from Aug 15, 2018

Conversation

davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Jul 24, 2018 •
edited

Edits: 2018-08-01

This PR got expanded (scope creeped) and now adds a number of sponsors to the footer.

Brand guidelines & assets

In general, I followed the following the below guidelines except I did desaturate any color if no black and white logo was provided.

Screenshot

screen shot 2018-08-01 at 10 30 52 am

@davidfischer davidfischer requested a review from a team July 24, 2018 20:36
@RichardLitt
Copy link
Member

Looks good to me.

@ericholscher
Copy link
Member

This looks good. I think it might be more useful to specify a bit more about what they are providing us. I really like what https://pypi.org/ does here:

screenshot 2018-08-01 09 21 11

So we could do something like:

Cloudflare
DNS & SSL certificates

@humitos
Copy link
Member

humitos commented Aug 1, 2018

I like Eric's proposal.

We may want to include together with Cloudflare other services that we use (although, I'm not sure what's the contract we have with them: Azure, Sentry, New Relic, and maybe others that I'm missing here)

@davidfischer
Copy link
Contributor Author

I think it might be more useful to specify a bit more about what they are providing us

My plan was to link to the upcoming blog post on the subject but I think I like your proposal better.

@davidfischer davidfischer changed the title Add Cloudflare to the sponsors list and footer Add Sponsors list to footer Aug 1, 2018
@davidfischer
Copy link
Contributor Author

I have updated this PR and edited the description. This PR was changed to add a number of sponsors to the footer.

humitos
humitos approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@davidfischer
Copy link
Contributor Author

I'll wait on merging this until we are a little closer to the Azure switchover date.

ericholscher
ericholscher approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@humitos
Copy link
Member

humitos commented Aug 15, 2018

I suppose we can merge this PR.

@davidfischer davidfischer merged commit 79032b5 into master Aug 15, 2018
@davidfischer davidfischer deleted the davidfischer/cloudflare-sponsor-logo branch August 15, 2018 23:00
@davidfischer davidfischer mentioned this pull request Aug 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@humitos humitos humitos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidfischer @RichardLitt @ericholscher @humitos